Suppress FieldDoesNotExist raised from attribute on class definition
#1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we've found an attribute on a model class that from all we can see appears to be a field, but Django still raises `FieldDoesNotExist` we'll suppress it. This can appear if one uses the (undocumented) `Field(name=..., ...)` argument.
intgr
approved these changes
Jan 23, 2023
There was a problem hiding this comment.
Thanks, this is great! The explanation seems sound. I tried and this makes mypy 0.991 upgrade work without removing CI testing with old Django versions (#1260).
How on Earth this issue was related to mypy version remains a mystery to me.
If I was to have a guess, I would suspect it has to do with that mypy's plugin system calls our hooks at certain times. So in the case of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
If we've found an attribute on a model class that from all we can see appears to be a field, but Django still raises
FieldDoesNotExistwe'll suppress it.This can appear if one uses the (undocumented)
Field(name=..., ...)argument.Related issues
Closes #1261