Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reflect the deprecation of get_response being None. #1086

Merged
merged 2 commits into from
Sep 3, 2022
Merged

Reflect the deprecation of get_response being None. #1086

merged 2 commits into from
Sep 3, 2022

Commits on Sep 3, 2022

  1. Reflect the deprecation of get_response being None. 

    Signed-off-by: Zixuan James Li <[email protected]>
    @PIG208
    PIG208 committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    a3739f7 View commit details
    Browse the repository at this point in the history

  2. Type get_response with a callback protocol. 

    Otherwise, calling `self.get_response(request)` in a subclass of
`MiddlewareMixin` runs into `Invalid self argument` error.

This is a workaround for python/mypy#5485.

Signed-off-by: Zixuan James Li <[email protected]>
    @PIG208
    PIG208 committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    7550818 View commit details
    Browse the repository at this point in the history