Reflect the deprecation of get_response being None. #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PIG208
force-pushed
the
get-response-deprecation
branch
3 times, most recently
from
cb84f12 to
737f071
Compare
PIG208
added a commit
to PIG208/django-stubs
that referenced
this pull request
Aug 8, 2022
This fixes the CI starting occur on typeddjango#1086 and following PRs due to the release of Django 4.1 (https://docs.djangoproject.com/en/4.1/releases/4.1/) which shipped the change # Even if this relation is not to pk, we require still pk value. # The wish is that the instance has been already saved to DB, # although having a pk value isn't a guarantee of that. if self.instance.pk is None: raise ValueError( f"{instance.__class__.__name__!r} instance needs to have a primary " f"key value before this relationship can be used." ) in django/django#15318.
PIG208
added a commit
to PIG208/django-stubs
that referenced
this pull request
Aug 8, 2022
This fixes the CI starting occur on typeddjango#1086 and following PRs due to the release of Django 4.1 (https://docs.djangoproject.com/en/4.1/releases/4.1/) which shipped the change # Even if this relation is not to pk, we require still pk value. # The wish is that the instance has been already saved to DB, # although having a pk value isn't a guarantee of that. if self.instance.pk is None: raise ValueError( f"{instance.__class__.__name__!r} instance needs to have a primary " f"key value before this relationship can be used." ) in django/django#15318.
PIG208
added a commit
to PIG208/django-stubs
that referenced
this pull request
Aug 8, 2022
This fixes the CI starting occur on typeddjango#1086 and following PRs due to the release of Django 4.1 (https://docs.djangoproject.com/en/4.1/releases/4.1/) which shipped the change # Even if this relation is not to pk, we require still pk value. # The wish is that the instance has been already saved to DB, # although having a pk value isn't a guarantee of that. if self.instance.pk is None: raise ValueError( f"{instance.__class__.__name__!r} instance needs to have a primary " f"key value before this relationship can be used." ) in django/django#15318.
sobolevn
pushed a commit
that referenced
this pull request
Aug 8, 2022
This fixes the CI starting occur on #1086 and following PRs due to the release of Django 4.1 (https://docs.djangoproject.com/en/4.1/releases/4.1/) which shipped the change # Even if this relation is not to pk, we require still pk value. # The wish is that the instance has been already saved to DB, # although having a pk value isn't a guarantee of that. if self.instance.pk is None: raise ValueError( f"{instance.__class__.__name__!r} instance needs to have a primary " f"key value before this relationship can be used." ) in django/django#15318.
52 tasks
Signed-off-by: Zixuan James Li <[email protected]>
Otherwise, calling `self.get_response(request)` in a subclass of `MiddlewareMixin` runs into `Invalid self argument` error. This is a workaround for python/mypy#5485. Signed-off-by: Zixuan James Li <[email protected]>
PIG208
force-pushed
the
get-response-deprecation
branch
from
737f071 to
7550818
Compare
sobolevn
approved these changes
Sep 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
In Django 4.0,
get_responsecan no longer beNone(4.0 release notes).This affects
MiddlewareMixinand its subclasses.Related issues