Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge for 2.26.6 release #319

Merged
merged 11 commits into from
Feb 15, 2024
Merged

Merge for 2.26.6 release #319

merged 11 commits into from
Feb 15, 2024

Conversation

dmitrii-ubskii
Copy link
Member

Usage and product changes

We merge development into master for 2.26.6 release.

typedb-bot and others added 11 commits January 30, 2024 14:07
## Usage and product changes

We modify the behaviour of #310 which unified variables and labels to
have the same valid identifier syntax, which eliminated the capability
of variables to have a leading number. For example, the variable `$0`
was banned.

This PR reverts this specific behaviour, and enables usage of variables
with leading digits:
```
match
$1_a isa entity;
get;
```
is made valid again.

Testing specified in
typedb/typedb-behaviour#281

## Implementation

We split the identifier regexes and grammar rules that validated labels
and variables before, to be specific to `Variable` and `Label`
identifiers.
## Usage and product changes

We update VERSION to 2.26.6 and create release notes.
@typedb-bot
Copy link
Member

typedb-bot commented Feb 15, 2024

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Trivial Change

  • This change is trivial and does not require a code or architecture review.

Code

  • Packages, classes, and methods have a single domain of responsibility.
  • Packages, classes, and methods are grouped into cohesive and consistent domain model.
  • The code is canonical and the minimum required to achieve the goal.
  • Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
  • Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
  • The code is algorithmically efficient and scalable for the whole application.

Architecture

  • Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
  • Any required build and release automations are updated and/or implemented.
  • Any new components follows a consistent style with respect to the pre-existing codebase.
  • The architecture intuitively reflects the application domain, and is easy to understand.
  • The architecture has a well-defined hierarchy of encapsulated components.
  • The architecture is extensible and scalable.

@typedb-bot typedb-bot merged commit 9e89657 into master Feb 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants