-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement non-ascii variables in Java and Rust #310
Merged
flyingsilverfin
merged 6 commits into
typedb:master
from
flyingsilverfin:non-ascii-typeql
Jan 16, 2024
Merged
Implement non-ascii variables in Java and Rust #310
flyingsilverfin
merged 6 commits into
typedb:master
from
flyingsilverfin:non-ascii-typeql
Jan 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Review ChecklistDo not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed. Trivial Change
Code
Architecture
|
flyingsilverfin
added a commit
to typedb/typedb-driver
that referenced
this pull request
Jan 16, 2024
## Usage and product changes We update TypeQL and tests to ensure that support for Unicode TypeQL variable names (typedb/typeql#310) is included. ## Implementation - Update TypeDB artifacts, and TypeQL and Behaviour dependencies - Add missing steps to test a new case: `delete` queries that throw an exception with a specialised exception - Update README links
flyingsilverfin
added a commit
that referenced
this pull request
Feb 15, 2024
## Usage and product changes We modify the behaviour of #310 which unified variables and labels to have the same valid identifier syntax, which eliminated the capability of variables to have a leading number. For example, the variable `$0` was banned. This PR reverts this specific behaviour, and enables usage of variables with leading digits: ``` match $1_a isa entity; get; ``` is made valid again. Testing specified in typedb/typedb-behaviour#281 ## Implementation We split the identifier regexes and grammar rules that validated labels and variables before, to be specific to `Variable` and `Label` identifiers.
farost
pushed a commit
to farost/typedb-driver
that referenced
this pull request
Mar 21, 2024
## Usage and product changes We update TypeQL and tests to ensure that support for Unicode TypeQL variable names (typedb/typeql#310) is included. ## Implementation - Update TypeDB artifacts, and TypeQL and Behaviour dependencies - Add missing steps to test a new case: `delete` queries that throw an exception with a specialised exception - Update README links
farost
pushed a commit
to farost/typedb-driver
that referenced
this pull request
Mar 21, 2024
## Usage and product changes We update TypeQL and tests to ensure that support for Unicode TypeQL variable names (typedb/typeql#310) is included. ## Implementation - Update TypeDB artifacts, and TypeQL and Behaviour dependencies - Add missing steps to test a new case: `delete` queries that throw an exception with a specialised exception - Update README links
farost
pushed a commit
to farost/typedb-driver
that referenced
this pull request
Mar 21, 2024
## Usage and product changes We update TypeQL and tests to ensure that support for Unicode TypeQL variable names (typedb/typeql#310) is included. ## Implementation - Update TypeDB artifacts, and TypeQL and Behaviour dependencies - Add missing steps to test a new case: `delete` queries that throw an exception with a specialised exception - Update README links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
We update to TypeQL with Unicode support in both value and concept variables. This makes the following valid TypeQL:
We now require all Labels and Variables are valid unicode identifiers not starting with
_
.This change is fully backwards compatible. We also validate that Type Labels and Variables created using the TypeQL language builders in both Rust and Java are conforming to our Unicode specification.
What are the changes implemented in this PR?
_