Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement non-ascii variables in Java and Rust #310

Merged
merged 6 commits into from
Jan 16, 2024

Conversation

flyingsilverfin
Copy link
Member

@flyingsilverfin flyingsilverfin commented Jan 15, 2024

What is the goal of this PR?

We update to TypeQL with Unicode support in both value and concept variables. This makes the following valid TypeQL:

match $人 isa person, has name "Liu"; get  $人;
match $אדם isa person, has name "Solomon"; get $אדם;

We now require all Labels and Variables are valid unicode identifiers not starting with _.

This change is fully backwards compatible. We also validate that Type Labels and Variables created using the TypeQL language builders in both Rust and Java are conforming to our Unicode specification.

What are the changes implemented in this PR?

  • Refactor variable names to allow the same range of characters as Labels - which is unicode identifier excluding a leading _
  • Add language builder validation for the strings provided to Labels or Variable names
  • Update typedb-behaviour

@typedb-bot
Copy link
Member

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Trivial Change

  • This change is trivial and does not require a code or architecture review.

Code

  • Packages, classes, and methods have a single domain of responsibility.
  • Packages, classes, and methods are grouped into cohesive and consistent domain model.
  • The code is canonical and the minimum required to achieve the goal.
  • Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
  • Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
  • The code is algorithmically efficient and scalable for the whole application.

Architecture

  • Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
  • Any required build and release automations are updated and/or implemented.
  • Any new components follows a consistent style with respect to the pre-existing codebase.
  • The architecture intuitively reflects the application domain, and is easy to understand.
  • The architecture has a well-defined hierarchy of encapsulated components.
  • The architecture is extensible and scalable.

@flyingsilverfin flyingsilverfin merged commit 025798c into typedb:master Jan 16, 2024
4 of 5 checks passed
@flyingsilverfin flyingsilverfin deleted the non-ascii-typeql branch January 16, 2024 11:31
flyingsilverfin added a commit to typedb/typedb-driver that referenced this pull request Jan 16, 2024
## Usage and product changes

We update TypeQL and tests to ensure that support for Unicode TypeQL
variable names (typedb/typeql#310) is included.

## Implementation
- Update TypeDB artifacts, and TypeQL and Behaviour dependencies
- Add missing steps to test a new case: `delete` queries that throw an
exception with a specialised exception
- Update README links
flyingsilverfin added a commit that referenced this pull request Feb 15, 2024
## Usage and product changes

We modify the behaviour of #310 which unified variables and labels to
have the same valid identifier syntax, which eliminated the capability
of variables to have a leading number. For example, the variable `$0`
was banned.

This PR reverts this specific behaviour, and enables usage of variables
with leading digits:
```
match
$1_a isa entity;
get;
```
is made valid again.

Testing specified in
typedb/typedb-behaviour#281

## Implementation

We split the identifier regexes and grammar rules that validated labels
and variables before, to be specific to `Variable` and `Label`
identifiers.
farost pushed a commit to farost/typedb-driver that referenced this pull request Mar 21, 2024
## Usage and product changes

We update TypeQL and tests to ensure that support for Unicode TypeQL
variable names (typedb/typeql#310) is included.

## Implementation
- Update TypeDB artifacts, and TypeQL and Behaviour dependencies
- Add missing steps to test a new case: `delete` queries that throw an
exception with a specialised exception
- Update README links
farost pushed a commit to farost/typedb-driver that referenced this pull request Mar 21, 2024
## Usage and product changes

We update TypeQL and tests to ensure that support for Unicode TypeQL
variable names (typedb/typeql#310) is included.

## Implementation
- Update TypeDB artifacts, and TypeQL and Behaviour dependencies
- Add missing steps to test a new case: `delete` queries that throw an
exception with a specialised exception
- Update README links
farost pushed a commit to farost/typedb-driver that referenced this pull request Mar 21, 2024
## Usage and product changes

We update TypeQL and tests to ensure that support for Unicode TypeQL
variable names (typedb/typeql#310) is included.

## Implementation
- Update TypeDB artifacts, and TypeQL and Behaviour dependencies
- Add missing steps to test a new case: `delete` queries that throw an
exception with a specialised exception
- Update README links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants