Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the following issues which makes the build 'dirty' #4803

Closed
lolski opened this issue Jan 13, 2019 · 2 comments
Closed

Fix the following issues which makes the build 'dirty' #4803

lolski opened this issue Jan 13, 2019 · 2 comments
Assignees
@vmax
Labels
domain: build status: solved type: bug

Comments

@lolski
Copy link
Member

lolski commented Jan 13, 2019 •
edited by vmax
Loading

  1. : lib.bzl is deprecated
DEBUG: /private/var/tmp/_bazel_haikalpribadi/3cdeaa1301f056ec7b4e7ee46bda5c79/external/bazel_skylib/lib.bzl:30:1: WARNING: lib.bzl is deprecated and will go away in the future, please directly load the bzl file(s) of the module(s) needed as it is more efficient.
  1. Attempting to add duplicate files
INFO: From PackageTar console/grakn-core-console.tar.gz:
Duplicate file in archive: ./console/services/lib/US_export_policy.jar, picking first occurrence
Duplicate file in archive: ./console/services/lib/local_policy.jar, picking first occurrence
INFO: From PackageTar server/grakn-core-server.tar.gz:
Duplicate file in archive: ./server/services/lib/US_export_policy.jar, picking first occurrence
Duplicate file in archive: ./server/services/lib/local_policy.jar, picking first occurrence
@lolski lolski added this to the v1.6 milestone Jan 13, 2019
@grabl grabl added the v1.6 label Jan 13, 2019
@vmax vmax mentioned this issue Feb 26, 2019
Merged
haikalpribadi pushed a commit to typedb/typedb-driver-nodejs that referenced this issue Feb 26, 2019
@vmax @haikalpribadi
Bump @bazelbuild_rules_nodejs version to latest 'experimental' (#16)
c3d9179 
## What is the goal of this PR?

Fixes first part of typedb/typedb#4803

## What are the changes implemented in this PR?

Upgrades `@build_bazel_rules_nodejs` to a version that includes a fix to 

````
DEBUG: /private/var/tmp/_bazel_<>/<>/external/bazel_skylib/lib.bzl:30:1: WARNING: lib.bzl is deprecated and will go away in the future, please directly load the bzl file(s) of the module(s) needed as it is more efficient.
````
@vmax vmax mentioned this issue Feb 27, 2019
Merged
haikalpribadi pushed a commit to typedb/bazel-distribution that referenced this issue Feb 28, 2019
@vmax @haikalpribadi
Remove unneeded files from distribution (#57)
a4a0453 
## What is the goal of this PR?

Fixes second part of typedb/typedb#4803

## What are the changes implemented in this PR?

Removed unneeded files from local JDK from distribution which also solves the problem (duplicated files were there)
@haikalpribadi
Copy link
Member

This has been labelled in progress for a while now. What's the status of this issue @vmax ?

@vmax
Copy link
Contributor

vmax commented Mar 8, 2019

@haikalpribadi I believe it was fixed by typedb/bazel-distribution#63

@vmax vmax closed this as completed Mar 8, 2019
@marco-scoppetta marco-scoppetta removed this from the 1.6.0 milestone Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vmax vmax

Labels
domain: build status: solved type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@lolski @vmax @haikalpribadi @marco-scoppetta @grabl