Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix implementation of java_deps #63

Merged
merged 1 commit into from
Mar 6, 2019
Merged

Fix implementation of java_deps #63

merged 1 commit into from
Mar 6, 2019

Conversation

vmax
Copy link
Contributor

@vmax vmax commented Mar 6, 2019

What is the goal of this PR?

Fixes #62

What are the changes implemented in this PR?

  • removes default value for java_deps_root attr
  • skips duplicated files

@vmax vmax requested a review from lolski March 6, 2019 18:03
@haikalpribadi haikalpribadi merged commit c18fd8d into master Mar 6, 2019
@haikalpribadi haikalpribadi deleted the java-deps-fixes branch March 6, 2019 20:24
@vmax vmax mentioned this pull request Mar 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolski lolski lolski approved these changes

Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vmax @lolski @haikalpribadi