This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Adapt to latest @graknlabs_bazel_distribution #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolski
approved these changes
Sep 18, 2019
lolski
approved these changes
Sep 18, 2019
| # TODO: rename the macro we load here to deploy_github_dependencies | ||
| load("@graknlabs_bazel_distribution//github:dependencies.bzl", "github_dependencies_for_deployment") | ||
| github_dependencies_for_deployment() | ||
| load("@graknlabs_bazel_distribution//github:dependencies.bzl", "tcnksm_ghr") |
There was a problem hiding this comment.
any chance we can use a slightly more descriptive name for whatever this is??
There was a problem hiding this comment.
@flyingsilverfin this follows an established convention of naming macros which load Bazel repos from GitHub repositories: github_org_repo_name. By that logic, tcnksm_ghr is named like it is 🙂
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
Newest changes in
bazel-distribution(typedb/bazel-distribution#181) are backwards-incompatible.What are the changes implemented in this PR?
@graknlabs_build_tools's versionbazel-distributionversion