Adapt @graknlabs_bazel_distribution to @rules_pkg #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolski
approved these changes
Sep 18, 2019
haikalpribadi
pushed a commit
to typedb/typedb
that referenced
this pull request
Sep 18, 2019
## What is the goal of this PR? Newest changes in `bazel-distribution` (typedb/bazel-distribution#181) are backwards-incompatible. ## What are the changes implemented in this PR? - Bump `@graknlabs_build_tools`'s version - Uses workspace macros from most recent `bazel-distribution` version - Remove Grakn Core archive after unpacking in RPM spec file
This was referenced Sep 18, 2019
haikalpribadi
pushed a commit
to typedb/typedb-driver
that referenced
this pull request
Sep 18, 2019
## What is the goal of this PR? Newest changes in `bazel-distribution` (typedb/bazel-distribution#181) are backwards-incompatible. ## What are the changes implemented in this PR? - Bump `@graknlabs_build_tools`'s version - Uses workspace macros from most recent `bazel-distribution` version
vmax
added a commit
to typedb/typedb-driver-nodejs
that referenced
this pull request
Sep 18, 2019
## What is the goal of this PR? Newest changes in `bazel-distribution` (typedb/bazel-distribution#181) are backwards-incompatible. ## What are the changes implemented in this PR? - Bump `@graknlabs_build_tools`'s version - Uses workspace macros from most recent `bazel-distribution` version
vmax
added a commit
to typedb/typedb-driver-python
that referenced
this pull request
Sep 18, 2019
## What is the goal of this PR? Newest changes in `bazel-distribution` (typedb/bazel-distribution#181) are backwards-incompatible. ## What are the changes implemented in this PR? - Bump `@graknlabs_build_tools`'s version - Uses workspace macros from most recent `bazel-distribution` version
vmax
added a commit
to typedb/typedb-protocol
that referenced
this pull request
Sep 18, 2019
## What is the goal of this PR? Newest changes in `bazel-distribution` (typedb/bazel-distribution#181) are backwards-incompatible. ## What are the changes implemented in this PR? - Uses workspace macros from most recent `bazel-distribution` version
haikalpribadi
pushed a commit
to typedb/typeql
that referenced
this pull request
Sep 19, 2019
## What is the goal of this PR? Newest changes in `bazel-distribution` (typedb/bazel-distribution#181) are backwards-incompatible. ## What are the changes implemented in this PR? Use workspace macros from most recent `bazel-distribution` version
This was referenced Sep 20, 2019
vmax
added a commit
to typedb/typedb-studio
that referenced
this pull request
Sep 23, 2019
## What is the goal of this PR? Newest changes in `bazel-distribution` (typedb/bazel-distribution#181) are backwards-incompatible and cause CI to fail. ## What are the changes implemented in this PR? - Bump `@graknlabs_build_tools`'s version - Uses workspace macros from most recent `bazel-distribution` version - Load `common` and `console` as they are needed to build `grakn-core-all` distribution used in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
Reduce potential tech debt and allow further upgrade to Bazel 0.29.1 and Python 3 by no longer using built-in obsolete
pkg_deb/pkg_rpm/pkg_tarrulesWhat are the changes implemented in this PR?
common/java_deps.bzl:depsetis no longer iterable inbazel 0.29.1[--incompatible_depset_is_not_iterable=trueby default], therefore we have to first convert it into a listbazelbuild_rules_pkgwhich now provide now-deprecatedpkg_deb/pkg_rpm/pkg_tarapt/pkg_deb_modified_from_bazelpackage since it's no longer neededgithub_dependencies_for_deploymenttotcnksm_ghrfor macros to have consistent namingreleaseto RPM targets (it's now a required attribute)