fix: implement cacheKeyForTree
that returns null
#1424
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: implement
cacheKeyForTree
that returnsnull
This fixes a bug between
ember-cli-typescript
,ember-engines
dedupe, andember-cli-babel
.ember-cli-babel
uses the existence ofember-cli-typescript
as a dependency to determine whether to process*.ts
files; however,ember-engines
dedupe is stateful so it's possible forember-cli-typescript
to not be a dependency whenember-cli-babel
is running.For more info on
ember-engines
dedupe logic: https://github.com/ember-engines/ember-engines/blob/master/packages/ember-engines/lib/utils/deeply-non-duplicated-addon.js#L35For more info on how
ember-cli-babel
determines whether to process*.ts
: https://github.com/babel/ember-cli-babel/blob/master/lib/babel-options-util.js#L407