Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _shouldHandleTypeScript to read from pkg.dependencies instead of relying on addons #400

Merged
merged 2 commits into from
Apr 28, 2021

Conversation

brendenpalmer
Copy link
Contributor

This fixes a bug between ember-cli-typescript, ember-engines dedupe, and ember-cli-babel. ember-cli-babel uses the existence of ember-cli-typescript as a dependency to determine whether to process *.ts files; however, ember-engines dedupe is stateful so it's possible for ember-cli-typescript to not be a dependency (part of addons) when ember-cli-babel is running.

For more info on ember-engines dedupe logic: https://github.com/ember-engines/ember-engines/blob/master/packages/ember-engines/lib/utils/deeply-non-duplicated-addon.js#L35

lib/babel-options-util.js Outdated Show resolved Hide resolved
lib/babel-options-util.js Outdated Show resolved Hide resolved
lib/babel-options-util.js Outdated Show resolved Hide resolved
@brendenpalmer brendenpalmer marked this pull request as ready for review April 26, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants