Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update example.env #144

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −1
Open

Update example.env #144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion server/example.env
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ TWIML_APP_SID=APxxxxxxxxxxxxxx
CALLER_ID=+11234567890

# Push credential for incoming calls
# Please see https://github.com/twilio/twilio-voice-react-native#incoming-calls
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of removing, do we have an updated link that provides more information about incoming calls, push credential sid, etc?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As someone who attempted to use this, I could not finish this without the documentation that was supposed to be at the link. If someone like me should be able to use this in the future, this is definitely important 👍

# If you do not plan to support incoming calls for one or more platforms,
# you can comment out one or more of the following push credentials lines.
APN_PUSH_CREDENTIAL_SID=xxxxxxxxxxxxxx
Expand Down