Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example.env #144

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mhuynh5757
Copy link
Contributor

Submission Checklist

  • The README.md reflects new features
  • The CHANGELOG.md reflects any feature, bug fixes, or known issues made in the source code
  • New unit tests and integration tests have beed added
  • Code coverage is more or equal to the previous coverage
  • A visual inspection of the Files changed tab was made prior to submitting the pull request ensuring the style guide was followed
  • CI pipeline is green
  • Included screenshot if necessary

Description

This PR removes a broken link from our server/example.env file. Thanks to #143 for bringing this to our attention.

Breakdown

  • Remove broken link.

Validation

  • N/A

Additional Notes

N/A

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@@ -22,7 +22,6 @@ TWIML_APP_SID=APxxxxxxxxxxxxxx
CALLER_ID=+11234567890

# Push credential for incoming calls
# Please see https://github.com/twilio/twilio-voice-react-native#incoming-calls
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of removing, do we have an updated link that provides more information about incoming calls, push credential sid, etc?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As someone who attempted to use this, I could not finish this without the documentation that was supposed to be at the link. If someone like me should be able to use this in the future, this is definitely important 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants