enhancement(http/routing): improve test coverage #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve the test coverage of the `twilight_http::routing::route_display` module by testing the `Display` implementations of routes. This also fixes route implementations for three routes, discovered by creating these tests: - Create Guild Prune w/ `include_roles` query param - Sync Guild Integration - Update Current User Voice State Signed-off-by: Zeyla Hellyer <[email protected]>
Signed-off-by: Zeyla Hellyer <[email protected]>
zeylahellyer
deleted the
enhancement-http-route-display-test-coverage
branch
7596ff
added a commit
that referenced
this pull request
Dec 15, 2021
Additions Add the API error codes `20029 WriteActionsReached` and `50055 InvalidGuild` ([#1326] - [@zeylahellyer]). Changes Only send the interaction authorization token when responding to interactions ([#1317] - [@zeylahellyer]). Fixes Fix an issue where interaction and webhook tokens were invalidating the entire client ([#1318] - [@zeylahellyer]). The client now only invalidates a token if the request that failed was actually using it. `CommandBorrowed::kind` is now properly serialized as `type` ([#1323] - [@7596ff]). Fix a variety of routes in `RouteDisplay` after adding tests ([#1327] - [@zeylahellyer]). The fixed routes are `CreateGuildPrune`, `SyncGuildIntegration`, and `UpdateUserVoiceState`. [#1317]: #1317 [#1318]: #1318 [#1323]: #1323 [#1326]: #1326 [#1327]: #1327 [@7596ff]: https://github.com/7596ff [@zeylahellyer]: https://github.com/zeylahellyer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the test coverage of the
twilight_http::routing::route_displaymodule by testing theDisplayimplementations of routes.This also fixes route implementations for three routes, discovered by creating these tests:
include_rolesquery paramTodo: