enhancement(http): add error codes 20029 and 50055 #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add two new HTTP error codes: - 20029: The write action you are performing on the server has hit the write rate limit[1] - 50055: Invalid Guild[2] [1]: discord/discord-api-docs#4214 [2]: discord/discord-api-docs#4212 Signed-off-by: Zeyla Hellyer <[email protected]>
zeylahellyer
added
c-http
|
Part of #1171. |
7596ff
approved these changes
Dec 11, 2021
Codecov Report
@@ Coverage Diff @@
## main #1326 +/- ##
=======================================
Coverage 30.97% 30.98%
=======================================
Files 365 365
Lines 14495 14501 +6
=======================================
+ Hits 4490 4493 +3
- Misses 10005 10008 +3
Continue to review full report at Codecov.
|
Erk-
approved these changes
Dec 11, 2021
7596ff
added a commit
that referenced
this pull request
Dec 15, 2021
Additions Add the API error codes `20029 WriteActionsReached` and `50055 InvalidGuild` ([#1326] - [@zeylahellyer]). Changes Only send the interaction authorization token when responding to interactions ([#1317] - [@zeylahellyer]). Fixes Fix an issue where interaction and webhook tokens were invalidating the entire client ([#1318] - [@zeylahellyer]). The client now only invalidates a token if the request that failed was actually using it. `CommandBorrowed::kind` is now properly serialized as `type` ([#1323] - [@7596ff]). Fix a variety of routes in `RouteDisplay` after adding tests ([#1327] - [@zeylahellyer]). The fixed routes are `CreateGuildPrune`, `SyncGuildIntegration`, and `UpdateUserVoiceState`. [#1317]: #1317 [#1318]: #1318 [#1323]: #1323 [#1326]: #1326 [#1327]: #1327 [@7596ff]: https://github.com/7596ff [@zeylahellyer]: https://github.com/zeylahellyer
7596ff
added a commit
that referenced
this pull request
Dec 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two new HTTP error codes: