-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolved Typescript console errors #7408
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR addresses the removal of the ManyToMany relation option from the codebase, focusing on resolving TypeScript console errors and cleaning up related code.
- Removed 'ManyToMany' from RelationDefinitionType enum in generated GraphQL types
- Eliminated ManyToMany checks in filterAvailableTableColumns function
- Removed ManyToMany-related code and imports in isFieldCellSupported function
- Updated comments to reflect the removal of the 'Belongs to Many' option for relation fields
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
packages/twenty-front/src/modules/object-record/utils/filterAvailableTableColumns.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @harshit078!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it's still displayed on the option list, I'll fix
Log
|
@FelixMalfait @harshit078 |
## Description - This PR addresses the issues- - twentyhq#7404 - twentyhq#7359 - and builds on the existing logic from PR twentyhq#7360 - Handled the 4 Ts console errors --------- Co-authored-by: Félix Malfait <[email protected]>
Description
This PR addresses the issues-
Handled the 4 Ts console errors