Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup after removing ManyToMany option for relations #7404

Closed
BOHEUS opened this issue Oct 2, 2024 · 2 comments
Closed

Cleanup after removing ManyToMany option for relations #7404

BOHEUS opened this issue Oct 2, 2024 · 2 comments
Assignees
@harshit078

Comments

@BOHEUS
Copy link
Contributor

BOHEUS commented Oct 2, 2024

After changes from #7359, there are errors in console logs as ManyToMany option wasn't removed from whole codebase.
image
@kshitij-codes
Copy link

We simply have to remove these code snippets causing red squiggly right? I did it in my local setup earlier in the day, it didn't cause any visible issues. Should I do the same again and raise a PR for it? @BOHEUS

@harshit078
Copy link
Contributor

Already working on this, Will be pushing a fix for it.

@harshit078 harshit078 mentioned this issue Oct 2, 2024
Merged
FelixMalfait added a commit that referenced this issue Oct 3, 2024
@harshit078 @FelixMalfait
Resolved Typescript console errors (#7408)
3cd24d5 
## Description

- This PR addresses the issues-
   - #7404 
   -  #7359 
   - and builds on the existing logic from PR #7360
   
- Handled the 4 Ts console errors

---------

Co-authored-by: Félix Malfait <[email protected]>
@BOHEUS BOHEUS closed this as completed Oct 3, 2024
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Product development ✅ Oct 3, 2024
harshit078 added a commit to harshit078/twenty that referenced this issue Oct 14, 2024
@harshit078 @FelixMalfait
Resolved Typescript console errors (twentyhq#7408)
71374f0 
## Description

- This PR addresses the issues-
   - twentyhq#7404 
   -  twentyhq#7359 
   - and builds on the existing logic from PR twentyhq#7360
   
- Handled the 4 Ts console errors

---------

Co-authored-by: Félix Malfait <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harshit078 harshit078

Labels
None yet
Projects
Product development ✅
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@BOHEUS @kshitij-codes @harshit078