Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wip): tasks navigate to /objects/tasks with viewId #6528

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

Nabhag8848
Copy link
Contributor

ISSUE (BUG)

Fixes: #6523

Description:

  • Should work on Command Menu
  • Should also work on Global Goto Hotkeys
  • Should navigate with viewId, as when we click on Navigationbar it is navigating with viewId.

@FelixMalfait FelixMalfait marked this pull request as ready for review August 7, 2024 15:59
@FelixMalfait
Copy link
Member

Hey let's merge it like this even if you wanted to do followups, at least it's fixing the bug already! Thanks!

@FelixMalfait FelixMalfait merged commit e265efc into twentyhq:main Aug 7, 2024
3 checks passed
Copy link

github-actions bot commented Aug 7, 2024

Thanks @Nabhag8848 for your contribution!
This marks your 0th PR on the repo. You're top 0% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

The pull request updates the hotkey navigation paths to ensure tasks navigate correctly with the viewId, aligning with the navigation bar behavior.

  • GotoHotkeysEffect.tsx: Updated hotkey path for tasks to /objects/tasks?view=10817448-f640-4f39-b5de-22edbef01a3a.
  • CommandMenuCommands.ts: Corrected 'Go to Tasks' command path to /objects/tasks?view=10817448-f640-4f39-b5de-22edbef01a3a.

These changes ensure consistent navigation and prevent landing on a blank page.

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using global shortcut for tasks, page redirects to wrong URL
2 participants