Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using global shortcut for tasks, page redirects to wrong URL #6523

Closed
BOHEUS opened this issue Aug 3, 2024 · 6 comments · Fixed by #6528
Closed

Using global shortcut for tasks, page redirects to wrong URL #6523

BOHEUS opened this issue Aug 3, 2024 · 6 comments · Fixed by #6528

Comments

@BOHEUS
Copy link
Contributor

BOHEUS commented Aug 3, 2024

Scenario:

  1. Log in
  2. Click G and T (shortcut for redirecting to Tasks page)

Actual: Redirected URL is http://localhost:3001/tasks
Expected: Redirected URL must be http://localhost:3001/objects/tasks?view=10817448-f640-4f39-b5de-22edbef01a3a

Note: URL can't be http://localhost:3001/objects/tasks because it gives blank page, when user normally clicks on 'Tasks' button, page automatically redirects to the 'By status' sub-page

@Nabhag8848
Copy link
Contributor

Hey @BOHEUS started working on it.

@Nabhag8848
Copy link
Contributor

we need to fix this in two places -> also when we are opening CommandMenu CMD+K it has same issue with G + T

@Nabhag8848
Copy link
Contributor

@BOHEUS I noticed that on other gotohotkeys

  • for eg: for companiesG+C. if we open to /objects/companies without view= it does show table and doesn't show blank page. I tried to look but haven't found by default what view=id? is used there ?

  • Ain't we need the same behaviour like companies or do we need to solve all the gotohotkeys for all objects which includes view=id. cause it doesn't show up when navigation with hotkeys (for eg: in companies) but it does uses that view query internal .

@BOHEUS
Copy link
Contributor Author

BOHEUS commented Aug 5, 2024

I'll leave this decision to the @CoreTeamTwenty

@FelixMalfait
Copy link
Member

Thanks @BOHEUS for spotting this (and the other bugs!)
@Nabhag8848 you're right it's better to remain consistent and not introduce a different pattern, let's leave it without the view if it works but still fix the url. Thank you!

@Nabhag8848
Copy link
Contributor

Nabhag8848 commented Aug 5, 2024

@BOHEUS @FelixMalfait This happens same with /objects/notes (blankpage without view queryparam) - will fix too, lets see if we can make some reusable code for this - inorder to avoid it in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants