Fix total count in show page #6462
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
The changes fix the total count display on the show page by separately tracking records before and after the cursor and combining these counts.
- Modified
packages/twenty-front/src/modules/object-record/record-show/hooks/useRecordShowPagePagination.tsto track and combinetotalCountBeforeandtotalCountAfter. - Introduced logic to handle edge cases where total counts might be incorrectly combined.
- Ensured accurate total count display even when the count is 1.
Potential issue: The logic for combining counts might still lead to inaccuracies in some edge cases.
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
| const totalCount = | ||
| totalCountBefore === 0 | ||
| ? totalCountAfter === 0 | ||
| ? 1 | ||
| : totalCountAfter | ||
| : totalCountBefore; |
There was a problem hiding this comment.
style: Combining totalCountBefore and totalCountAfter using this logic might lead to incorrect counts if both are non-zero but not equal. Consider summing the counts instead.
|
@charlesBochet Can help with a review on this? |
prateekj117
force-pushed
the
bug/issue-6405
branch
2 times, most recently
from
9642211
to
ae8b44e
Compare
| if (totalCountBefore !== 0 && totalCountAfter !== 0) { | ||
| totalCount = Math.max(totalCountBefore, totalCountAfter); | ||
| } else { | ||
| totalCount = |
There was a problem hiding this comment.
totalCount = (totalCountBefore === 0 && totalCountAfter === 0) ? 1 : Math.max(totalCountBefore, totalCountAfter)
I believe this should work?
There was a problem hiding this comment.
Yup. That's a better way to write it. Let me correct this.
prateekj117
force-pushed
the
bug/issue-6405
branch
from
ae8b44e
to
e9ba016
Compare
|
@charlesBochet Ready for another round of review. |
| @@ -147,6 +148,11 @@ export const useRecordShowPagePagination = ( | |||
|
|
|||
| const objectLabel = capitalize(objectMetadataItem.namePlural); | |||
|
|
|||
| const totalCount = | |||
| totalCountBefore === 0 && totalCountAfter === 0 | |||
There was a problem hiding this comment.
Could be even shorter
const totalCount = Math.max(1, totalCountBefore, totalCountAfter)
prateekj117
force-pushed
the
bug/issue-6405
branch
from
e9ba016
to
2307a89
Compare
Fixes #6405 We need to take into account both the totalCount of **before cursor** results and **after cursor** results.
Fixes #6405
We need to take into account both the totalCount of before cursor results and after cursor results.