Skip to content

Commit

Permalink
Fix total count in show page (#6462)
Browse files Browse the repository at this point in the history
Fixes #6405 

We need to take into account both the totalCount of **before cursor**
results and **after cursor** results.
  • Loading branch information
prateekj117 authored Jul 30, 2024
1 parent 70f9df7 commit ee4f1da
Showing 1 changed file with 6 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ export const useRecordShowPagePagination = (

const cursorFromRequest = currentRecordsPageInfo?.endCursor;

const [totalCount, setTotalCount] = useState<number>(0);
const [totalCountBefore, setTotalCountBefore] = useState<number>(0);
const [totalCountAfter, setTotalCountAfter] = useState<number>(0);

const { loading: loadingRecordBefore, records: recordsBefore } =
useFindManyRecords({
Expand All @@ -78,7 +79,7 @@ export const useRecordShowPagePagination = (
objectNameSingular,
recordGqlFields,
onCompleted: (_, pagination) => {
setTotalCount(pagination?.totalCount ?? 0);
setTotalCountBefore(pagination?.totalCount ?? 0);
},
});

Expand All @@ -98,7 +99,7 @@ export const useRecordShowPagePagination = (
objectNameSingular,
recordGqlFields,
onCompleted: (_, pagination) => {
setTotalCount(pagination?.totalCount ?? 0);
setTotalCountAfter(pagination?.totalCount ?? 0);
},
});

Expand Down Expand Up @@ -147,6 +148,8 @@ export const useRecordShowPagePagination = (

const objectLabel = capitalize(objectMetadataItem.namePlural);

const totalCount = Math.max(1, totalCountBefore, totalCountAfter);

const viewNameWithCount = rankFoundInFiew
? `${rankInView + 1} of ${totalCount} in ${objectLabel}`
: `${objectLabel} (${totalCount})`;
Expand Down

0 comments on commit ee4f1da

Please sign in to comment.