add timezone and datetime formatting on workspace member level #5699

AdityaPimpalkar · 2024-05-31T21:49:32Z

closes: #5140

github-actions · 2024-05-31T21:50:21Z

TODOs/FIXMEs:

~~// TODO: use the user's saved time zone. If undefined, default it with the user's detected time zone.~~: packages/twenty-front/src/modules/settings/accounts/components/SettingsAccountsCalendarDisplaySettings.tsx
~~// TODO: use the user's saved date format.~~: packages/twenty-front/src/modules/settings/accounts/components/SettingsAccountsCalendarDisplaySettings.tsx
~~// TODO: use the user's saved time format.~~: packages/twenty-front/src/modules/settings/accounts/components/SettingsAccountsCalendarDisplaySettings.tsx

Generated by 🚫 dangerJS against 73034ac

greptile-apps

PR Summary

Added timezone and datetime formatting fields to WorkspaceMember type in GraphQL
Introduced DateTimeSettings component for user-specific datetime preferences
Refactored and moved timezone and datetime utilities to workspace-member module
Deleted redundant components and constants related to datetime settings
Updated mock data to include new timezone and datetime formatting properties

packages/twenty-front/src/modules/settings/profile/components/DateTimeSettings.tsx

packages/twenty-front/src/modules/workspace-member/utils/detectTimeFormat.ts

packages/twenty-front/src/modules/workspace-member/utils/formatDateLabel.ts

packages/twenty-front/src/modules/workspace-member/utils/formatTimeLabel.ts

...ty-server/src/modules/workspace-member/standard-objects/workspace-member.workspace-entity.ts

martmull

Hey, added some first comments, think we should use enums for workspace-member entity as you suggest, also we would like to create a graphql type to be able to use those enum values in the front

packages/twenty-front/src/modules/workspace-member/utils/formatDateLabel.ts

...ty-server/src/modules/workspace-member/standard-objects/workspace-member.workspace-entity.ts

packages/twenty-server/src/engine/core-modules/user/dtos/workspace-member.dto.ts

packages/twenty-front/src/modules/workspace-member/constants/TimeFormat.ts

packages/twenty-front/src/modules/workspace-member/constants/DateFormat.ts

greptile-apps

PR Summary

(updates since last review)

Introduced timezone and datetime formatting at the workspace member level
Updated GraphQL queries and mutations to use new DateFormat and TimeFormat enums
Enhanced DateTimeSettings.tsx for granular control over date and time settings
Added new fields and enums for timeZone, dateFormat, and timeFormat in workspace-member.dto.ts
Updated workspace-member.workspace-entity.ts to define and use new enums for date and time formats

FelixMalfait · 2024-07-16T08:56:34Z

...ver/src/modules/workspace-member/standard-objects/options/workspace-member-locale.options.ts

@@ -0,0 +1,242 @@
+import { FieldMetadataComplexOption } from 'src/engine/metadata-modules/field-metadata/dtos/options.input';
+
+export enum WorkspaceMemberLocaleEnum {


Sorry but I don't think we'll realistically want to cover these any day. I thought we could do something simpler, no?

Cf Discord message:

closes twentyhq#5552 <img width="754" alt="Bildschirmfoto 2024-07-19 um 23 35 25" src="https://github.com/user-attachments/assets/715192cd-679d-430a-95f1-8bc1d8fd26f4">

@Bonapara

@Bonapara Fixed! the issue (twentyhq#6365) where the `background-color` style was not set, causing the bug. Now, the background color is properly applied. https://github.com/user-attachments/assets/668bd3cc-77ea-42a9-84d4-071fca497e07

…q#6377) # This PR - Fix twentyhq#6305

lucasbordeau · 2024-07-25T15:57:17Z

This PR commit history is dirty and there is a lot of changes here that we don't need on locale and colorScheme.

I create a new PR and handpicked the relevant changes : #6408

FelixMalfait · 2024-07-25T16:13:30Z

@lucasbordeau I don't really get your comment to be honest, the commit history get squashed. And as for the changes on locale and colorScheme this was an ask I made to @AdityaPimpalkar during review to remain consistent and avoid creating debt by having those inconsistencies between different fields. He did it because I asked

FelixMalfait · 2024-07-25T16:16:23Z

What was the issue with the PR? The vision is for WorkspaceMember is to become an object visible in the UI at somepoint, we're trying to migrate everything to standard objects (like the work we're doing on Note/Task). The work done by @AdityaPimpalkar was in line with that long-term vision

AdityaPimpalkar added 4 commits May 31, 2024 22:40

detect browser date time format

fb27840

move constants and utils from settings to workspace member

1af562d

introduce date time states

363ca8d

move DateTimeSettings to profile section

8c41f58

AdityaPimpalkar added 6 commits June 3, 2024 00:08

add timeZone, dateFormat and timeFormat columns to workspace member

820691d

add utils and enums to format date time labels

e4673d9

update WorkspaceMember type on front end

45f18aa

add date time fields to currentWorkspaceMemberState on sign in

a8f5181

format using currentWorkspaceMember

0fcfe94

update mock data

5905659

AdityaPimpalkar marked this pull request as ready for review June 2, 2024 23:14

greptile-apps bot reviewed Jun 2, 2024

View reviewed changes

AdityaPimpalkar commented Jun 2, 2024

View reviewed changes

...ty-server/src/modules/workspace-member/standard-objects/workspace-member.workspace-entity.ts Outdated Show resolved Hide resolved

lint fix

eb3865d

martmull reviewed Jun 3, 2024

View reviewed changes

martmull added the -PR: awaiting author label Jun 3, 2024

values as enums for dateformat and timeformat

e48a87c

greptile-apps bot reviewed Jun 6, 2024

View reviewed changes

AdityaPimpalkar added 11 commits June 6, 2024 23:12

Merge branch 'main' into datetime-formatting

82832ae

gql codegen

b082718

add prefix 'preferred'

cfbef7b

lint fix

617a7c9

rename DateFormat to WorkspaceMemberDateFormatEnum

8c9412a

remove prefix "preferred"

050fefe

add methods to convert to workspace enums

00ed339

add SYSTEM to DateFormat and TimeFormat enums

72ee43b

adapt workspace member date time format across datetime display fields

81807df

Merge branch 'main' into datetime-formatting

1feebb1

graphql codegen

6739486

AdityaPimpalkar added 6 commits July 12, 2024 11:56

colorScheme values as enums

3e5701f

lint fix

d50cccf

type fix

0fa8f2a

lint fix

405cfb4

locale value as enum

6282ff9

fix typecheck

6b3fd0c

FelixMalfait reviewed Jul 16, 2024

View reviewed changes

AdityaPimpalkar and others added 19 commits July 19, 2024 14:34

simplify WorkspaceMemberLocaleEnum

9b29877

Merge branch 'main' into datetime-formatting

372acbf

lint fix

2b1c22c

typecheck and story fix

da39d91

import fix

ce7637b

Merge branch 'main' into datetime-formatting

ebb3540

Fix task text overflow (twentyhq#6351)

c811e64

closes twentyhq#5552 <img width="754" alt="Bildschirmfoto 2024-07-19 um 23 35 25" src="https://github.com/user-attachments/assets/715192cd-679d-430a-95f1-8bc1d8fd26f4">

Fix mocks for unlogged users (twentyhq#6376)

c7b8db3

Fix RecordTableHeaderCell (twentyhq#6383)

6ee8c92

@Bonapara Fixed! the issue (twentyhq#6365) where the `background-color` style was not set, causing the bug. Now, the background color is properly applied. https://github.com/user-attachments/assets/668bd3cc-77ea-42a9-84d4-071fca497e07

chore: remove the passwordResetToken field from the database (twentyh…

fd6f37b

…q#6377) # This PR - Fix twentyhq#6305

Use LinksMetadata right type for Links fields (twentyhq#6380)

46eed1b

Fixed TimelineCalendarEvent typing

4822648

Reverted changes on already existing fields

480985a

Fixed GraphQL bug

c62ec5f

Fixed bug on database without new fields

4f19b48

Fixed new settings with null value

2b985fa

Updated graphql schema

747eea7

Removed refactor of color scheme and locale

dd06dea

Fix

73034ac

lucasbordeau closed this Jul 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add timezone and datetime formatting on workspace member level #5699

add timezone and datetime formatting on workspace member level #5699

AdityaPimpalkar commented May 31, 2024

github-actions bot commented May 31, 2024 •

edited

Loading

greptile-apps bot left a comment

martmull left a comment

greptile-apps bot left a comment

FelixMalfait Jul 16, 2024

AdityaPimpalkar Jul 19, 2024

lucasbordeau commented Jul 25, 2024

FelixMalfait commented Jul 25, 2024

FelixMalfait commented Jul 25, 2024

		@@ -0,0 +1,242 @@
		import { FieldMetadataComplexOption } from 'src/engine/metadata-modules/field-metadata/dtos/options.input';

		export enum WorkspaceMemberLocaleEnum {

add timezone and datetime formatting on workspace member level #5699

add timezone and datetime formatting on workspace member level #5699

Conversation

AdityaPimpalkar commented May 31, 2024

github-actions bot commented May 31, 2024 • edited Loading

TODOs/FIXMEs:

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

martmull left a comment

Choose a reason for hiding this comment

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

FelixMalfait Jul 16, 2024

Choose a reason for hiding this comment

AdityaPimpalkar Jul 19, 2024

Choose a reason for hiding this comment

lucasbordeau commented Jul 25, 2024

FelixMalfait commented Jul 25, 2024

FelixMalfait commented Jul 25, 2024

github-actions bot commented May 31, 2024 •

edited

Loading