Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove the passwordResetToken field from the database #6377

Merged
merged 1 commit into from
Jul 24, 2024
Merged

chore: remove the passwordResetToken field from the database #6377

merged 1 commit into from
Jul 24, 2024

Conversation

pacyL2K19
Copy link
Contributor

greptile-apps[bot]
greptile-apps bot reviewed Jul 23, 2024
View reviewed changes
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR removes the passwordResetToken field from the database, aligning with the new password reset approach via the appToken table.

  • Added packages/twenty-server/src/database/typeorm/core/migrations/1721738579379-DeletePasswordResetToken.ts to drop passwordResetToken and passwordResetTokenExpiresAt columns from core.user.
  • Modified packages/twenty-server/src/engine/core-modules/auth/auth.resolver.ts to reorganize import statements related to password reset functionality.
  • Updated packages/twenty-server/src/engine/core-modules/user/user.entity.ts to remove passwordResetToken and passwordResetTokenExpiresAt fields from the User entity.

3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

charlesBochet
charlesBochet approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @pacyL2K19 !

@charlesBochet charlesBochet merged commit 6785a2b into twentyhq:main Jul 24, 2024
4 checks passed
@github-actions GitHub Actions
Copy link

Thanks @pacyL2K19 for your contribution!
This marks your 1st PR on the repo. You're top 17% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

@pacyL2K19 pacyL2K19 deleted the chore/remove-password-reset-token branch July 24, 2024 08:50
lucasbordeau pushed a commit to AdityaPimpalkar/twenty that referenced this pull request Jul 24, 2024
@pacyL2K19 @lucasbordeau
chore: remove the passwordResetToken field from the database (twentyh…
fd6f37b 
…q#6377)

# This PR

- Fix twentyhq#6305
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

@charlesBochet charlesBochet charlesBochet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delete passwordResetToken and passwordResetTokenExpiresAt in users table
2 participants
@pacyL2K19 @charlesBochet