Make stack_snapshot usable from another's module extension #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylecornec
force-pushed
the
ylecornec/stack_snapshot_other_module
branch
from
9c321ce to
e868628
Compare
Closed
6 tasks
ylecornec
force-pushed
the
ylecornec/pre_bzlmod_refactoring
branch
from
f5d8e9f to
8988b52
Compare
ylecornec
force-pushed
the
ylecornec/stack_snapshot_other_module
branch
from
e868628 to
b4ad151
Compare
|
🎉 All dependencies have been resolved ! |
With bzlmod, when using `stack_snapshot` in a module extension of another module, rules_haskell does not have visibility of generated repositories (such as `rules_haskell_stack`) and cannot build labels to its targets using the `Label` constructor. To work around this, an optional `label_builder` parameter can be passed to `stack_snapshot`, which is then used to canonicalize various labels. For the same reason, the `stack_update` attribute to `_stack_snapshot` is now always present (so we do not have to hardcode its label), and is made into a string so that we only fetch the `stack_update` repository when explicitly reading from it.
ylecornec
force-pushed
the
ylecornec/stack_snapshot_other_module
branch
from
b4ad151 to
2b13e62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1905
This PR makes the
stack_snapshotrepository rule usable from anon_module_depextension of another module thanrules_haskell(such asrules_haskell_tests).These changes are needed because with bzlmod, when
stack_snapshotis called by an extension of another module, rules_haskell does not have visibility of generated repositories (such asrules_haskell_stack) and cannot build labels to its targets using theLabelconstructor.To work around this, an optional
label_builderparameter can be passed tostack_snapshot, which can be used to build labels from the context of the caller modules extension and obtain their canonical names. Once we provide our own module extension to install stackage packages (Add a module extension for Stackage packages #1899), thislabel_builderparameter should not be necessary anymore.For the same reason, the
stack_updateattribute to_stack_snapshotis now always present (so we do not have to hardcode its label), and is made into a string so that we only fetch thestack_updaterepository when explicitly reading from it.