Refactoring for bzlmod #1905
Merged
Refactoring for bzlmod #1905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
6 tasks
|
🎉 All dependencies have been resolved ! |
This repository rule only provides rules_haskell dependencies which are not available as bzlmod modules
In bzlmod buildifier is only a dev dependency of rules_haskell. So buildifier targets should not be in the same package as public targets such as `//:distribution`
For consistency with `rules_haskell`, buildifier can also be run with `bazel run //buildifier`
- io_bazel_stardoc is now available as a module - we will rely on a module extension from rules_js to install webpack instead of using asterius_dependencies_* rules
ylecornec
force-pushed
the
ylecornec/pre_bzlmod_refactoring
branch
from
f5d8e9f to
8988b52
Compare
avdv
approved these changes
Jun 12, 2023
ylecornec
force-pushed
the
ylecornec/pre_bzlmod_refactoring
branch
from
494d170 to
3a10e22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1903
This PR contains some more refactoring in preparation for bzlmod.
rules_haskell_dependencies_bzlmodfunction that only contains dependencies that are not available as modules. So their definition is shared between bzlmod and workspace modes.non_module_depsfiles directly to the WORKSPACE file.buildifierpackages.