Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim dependencies for better integration with dApp codebases #69

Closed
kk-hainq opened this issue Jan 5, 2022 · 4 comments
Closed

Trim dependencies for better integration with dApp codebases #69

kk-hainq opened this issue Jan 5, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@kk-hainq
Copy link

kk-hainq commented Jan 5, 2022

Is your feature request related to a problem? Please describe.
I'd like to integrate this library into our codebase but the dependencies according to the current plutus-apps release is quite heavy-weight and easy to conflict with newer dependencies.

Describe the solution you'd like
Aggressively trimming dependencies on the next plutus-apps release would save a lot of resources building this library for both maintainers and library users. Fewer dependencies mean fewer conflicting risks integrating the library into dApp codebases as well.

Describe alternatives you've considered
Having to revert existing dependencies and API breaking change fixes, and add unused dependencies to integrate this library into our dApp codebase.

Additional context
Upstream is already moving well on this end:

I'd love to open a PR to do this after the next plutus-apps release!

@VictorCMiraldo VictorCMiraldo added the enhancement New feature or request label Jan 5, 2022
@VictorCMiraldo
Copy link
Contributor

I 100% agree with that. We'd be happy to accept a PR too! Thanks! :)

@kk-hainq
Copy link
Author

kk-hainq commented Jan 5, 2022

Can we trade merged PRs for future discounts, Victor? 😢

@VictorCMiraldo
Copy link
Contributor

I wish I could have a say in that, but that's way above my pay-grade, unfortunately! :lol:

@mmontin
Copy link
Collaborator

mmontin commented Mar 13, 2024

Closing because this was handled when moving to cooked v2.

@mmontin mmontin closed this as completed Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants