Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine dependencies and remove unused packages #214

Merged
merged 3 commits into from
Jan 20, 2022

Conversation

kk-hainq
Copy link
Contributor

@kk-hainq kk-hainq commented Dec 23, 2021

The main goal is to refine the Nix/Cabal setup and remove unused packages. The followings are completely removed:

  • cardano-crypto-tests.
  • lobemo-backend-aggregation.
  • lobemo-backend-monitoring.
  • lobemo-backend-trace-forwarder.
  • lobemo-scribe-systemd.
  • shelley-spec-ledger (this was used, just replaced with something new).
  • shelley-spec-ledger-test (this was used, just replaced with something new).

I went from an empty cabal.project so I took the liberty to draw a dependency updating process, as I think there wasn't a concrete one before. For now:

  • Just keep iohk-monitoring-framework as is until upstream updates develop/master that addresses the comment in cabal.project.
  • Update plutus when new changes are desired, like better script sizes for plutus-apps demos, tests, and use cases.
  • Make flat follow plutus.
  • Update servant-purescript & purescript-bridge when new changes are desired.
  • Update cardano-wallet when new changes are desired.
  • Make these follow cardano-wallet:
    • cardano-node
    • cardano-ledger
    • ouroboros-network
    • cardano-base
    • cardano-prelude
    • cardano-crypto
    • cardano-addresses
    • goblins
    • Win32-network

It is preferred to track a stable node release through cardano-wallet. This PR tracks the latest 1.33.0 release, and naturally resolves #240.

The third commit is updateMaterialized so reviewing the others should be enough.

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@kk-hainq kk-hainq force-pushed the bump-deps-remove-unused-packages branch 3 times, most recently from 8ade751 to 4ac446d Compare December 23, 2021 08:38
@kk-hainq kk-hainq marked this pull request as draft December 23, 2021 09:10
@kk-hainq kk-hainq force-pushed the bump-deps-remove-unused-packages branch 2 times, most recently from 9025228 to 9cf098a Compare December 23, 2021 10:05
@kk-hainq kk-hainq marked this pull request as ready for review December 23, 2021 10:27
@kk-hainq kk-hainq force-pushed the bump-deps-remove-unused-packages branch 2 times, most recently from 5430f82 to f95eb1e Compare January 18, 2022 12:59
@kk-hainq kk-hainq force-pushed the bump-deps-remove-unused-packages branch from f95eb1e to ede50f5 Compare January 18, 2022 13:43
Copy link
Contributor

@raduom raduom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@silky silky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this work @kk-hainq !

@silky silky merged commit 8c82060 into IntersectMBO:main Jan 20, 2022
@kk-hainq kk-hainq deleted the bump-deps-remove-unused-packages branch January 20, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants