-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move psgenerator out of plutus-pab #216
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as draft
December 23, 2021 15:04
ghost
force-pushed
the
split-plutus-pab
branch
from
December 27, 2021 13:14
29c4da8
to
c2d2f03
Compare
ghost
marked this pull request as ready for review
December 28, 2021 08:40
ghost
force-pushed
the
split-plutus-pab
branch
from
December 30, 2021 11:30
566182a
to
f913fdf
Compare
ghost
mentioned this pull request
Dec 31, 2021
8 tasks
ghost
force-pushed
the
split-plutus-pab
branch
from
January 3, 2022 07:34
f913fdf
to
66cbadb
Compare
silky
approved these changes
Jan 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks; I'm happy pending the discussed changes to bring some minimal tests back to the plutus-pab
package :D
silky
approved these changes
Jan 4, 2022
raduom
approved these changes
Jan 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
koslambrou
reviewed
Jan 4, 2022
koslambrou
approved these changes
Jan 4, 2022
ghost
force-pushed
the
split-plutus-pab
branch
from
January 5, 2022 14:59
bbc059e
to
7b46473
Compare
ghost
deleted the
split-plutus-pab
branch
January 5, 2022 16:18
ghost
mentioned this pull request
Jan 12, 2022
8 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
an attempt to fix #212
plutus-pab
toplutus-pab-executables
plutus-pab
, now lives in theplutus-pab-psgenerator
sublibrary inplutus-pab-executables
turned out this is necessary for
playground-common
in #223 removal as wellPre-submit checklist: