Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move psgenerator out of plutus-pab #216

Merged
3 commits merged into from
Jan 5, 2022
Merged

Move psgenerator out of plutus-pab #216

3 commits merged into from
Jan 5, 2022

Conversation

ghost
Copy link

@ghost ghost commented Dec 23, 2021

an attempt to fix #212

  • moved all executables from plutus-pab to plutus-pab-executables
  • removed psgenerator from plutus-pab, now lives in the plutus-pab-psgenerator sublibrary in plutus-pab-executables

turned out this is necessary for playground-common in #223 removal as well


Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@ghost ghost marked this pull request as draft December 23, 2021 15:04
@ghost ghost marked this pull request as ready for review December 28, 2021 08:40
@ghost ghost mentioned this pull request Dec 31, 2021
8 tasks
Copy link
Contributor

@silky silky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks; I'm happy pending the discussed changes to bring some minimal tests back to the plutus-pab package :D

Copy link
Contributor

@raduom raduom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 337fc39 into main Jan 5, 2022
@ghost ghost deleted the split-plutus-pab branch January 5, 2022 16:18
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove mandatory playground and PureScript dependencies from PAB
3 participants