Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5: Drop .media #28265

Merged
merged 7 commits into from
May 8, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions scss/_media.scss

This file was deleted.

1 change: 0 additions & 1 deletion scss/bootstrap.scss
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
@import "jumbotron";
@import "alert";
@import "progress";
@import "media";
@import "list-group";
@import "close";
@import "toasts";
Expand Down
136 changes: 0 additions & 136 deletions site/content/docs/4.3/components/media-object.md

This file was deleted.

2 changes: 1 addition & 1 deletion site/content/docs/4.3/layout/overview.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
layout: docs
title: Overview
description: Components and options for laying out your Bootstrap project, including wrapping containers, a powerful grid system, a flexible media object, and responsive utility classes.
description: Components and options for laying out your Bootstrap project, including wrapping containers, a powerful grid system, and responsive utility classes.
group: layout
aliases: "/docs/4.3/layout/"
toc: true
Expand Down
2 changes: 1 addition & 1 deletion site/content/docs/4.3/migration.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ Changes to our source and compiled JavaScript files.

Changes to any layout tools and our grid system.

- Dropped `.media` component as it can be built with utility classes
- Dropped `.media` component as it can be built with utility classes. [See #28265](https://github.com/twbs/bootstrap/pull/28265).
- **Todo:** Remove `position: relative` from grid columns
- **Todo:** Integrate CSS grid into our grid system

Expand Down
10 changes: 5 additions & 5 deletions site/content/docs/4.3/utilities/stretched-link.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,13 @@ Multiple links and tap targets are not recommended with stretched links. However
</div>
{{< /example >}}

Media objects do not have `position: relative` by default, so we need to add the `.position-relative` here to prevent the link from stretching outside the media object.
Most custom components do not have `position: relative` by default, so we need to add the `.position-relative` here to prevent the link from stretching outside the parent element.

{{< example >}}
<div class="media position-relative">
{{< placeholder width="144" height="144" class="mr-3" text="false" title="Generic placeholder image" >}}
<div class="media-body">
<h5 class="mt-0">Media with stretched link</h5>
<div class="d-flex position-relative">
{{< placeholder width="144" height="144" class="flex-shrink-0 mr-3" text="false" title="Generic placeholder image" >}}
<div>
<h5 class="mt-0">Custom component with stretched link</h5>
<p>Cras sit amet nibh libero, in gravida nulla. Nulla vel metus scelerisque ante sollicitudin. Cras purus odio, vestibulum in vulputate at, tempus viverra turpis. Fusce condimentum nunc ac nisi vulputate fringilla. Donec lacinia congue felis in faucibus.</p>
<a href="#" class="stretched-link">Go somewhere</a>
</div>
Expand Down
1 change: 0 additions & 1 deletion site/data/nav.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
- title: Input group
- title: Jumbotron
- title: List group
- title: Media object
- title: Modal
- title: Navs
- title: Navbar
Expand Down