v5: Drop .media #28265
Merged
v5: Drop .media #28265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't use the |
XhmikosR
force-pushed
the
v5-drop-media
branch
from
1bc8ca0 to
e38b3ee
Compare
13 tasks
|
About the deprecation notice: we could just add a message to the |
|
Should be ready for review now, @twbs/css-review. |
|
There's still here: |
|
@ysds Done! |
|
@MartijnCuppens: LGTY? |
MartijnCuppens
approved these changes
May 8, 2019
rfr-odoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
Jul 5, 2022
rfr-odoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
Jul 5, 2022
rfr-odoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
Jul 7, 2022
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
Jul 7, 2022
eres-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Jul 19, 2022
crhistianramirez
pushed a commit
to crhistianramirez/headstart
that referenced
this pull request
Dec 28, 2022
Dropped the .media component as it can be easily replicated with utilities. See twbs/bootstrap#28265 and the flex utilities page for an example https://getbootstrap.com/docs/5.0/utilities/flex/#media-object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The media component is basically a series of utilities that have been assigned to a more unique name. This can all be done via our other utility classes.
_media.scssfileDeprecate the component in v4.3.2 /cc @MartijnCuppens (see v5: Drop .media #28265 (comment))