fix issue related to Object.keys and Dropdown issue #26291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsn4ik
reviewed
Apr 13, 2018
| @@ -331,7 +331,7 @@ const Collapse = (($) => { | |||
| const _config = { | |||
| ...Default, | |||
| ...$this.data(), | |||
| ...typeof config === 'object' && config | |||
| ...typeof config === 'object' && config ? config : {} | |||
There was a problem hiding this comment.
Why not
typeof config === 'object' ? config : {}?
There was a problem hiding this comment.
yep that can be enough thanks 👍
There was a problem hiding this comment.
Finally I won't make this change because it'll decrease our code coverage
XhmikosR
approved these changes
Apr 13, 2018
Closed
This was referenced Apr 16, 2018
sesemaya
added a commit
to Daemonite/material
that referenced
this pull request
Apr 18, 2018
This was referenced Apr 19, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #26266
/CC @XhmikosR