-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with IE11 and Bootstrap 4.1.0 #26327
Comments
To add more information, I created a code pen: https://codepen.io/dustinrowland12/pen/GdKzKL |
Already fixed by: #26291 and will be available in our next release 👍 |
Thank you for the quick reply. Any thoughts on when the next release may come out? I'm sure that is always the golden question. I just want to be on the lookout for it. Thanks again! |
We'll try to release a new version soon to fix some critical bugs. It'll be a 4.1.1 😉 |
Sorry to prod, but we're pushing back release for 4.1.1. Is there a timeline for 4.1.1 yet? |
Should remove <=IE11 from the list of supported browsers until then. |
@kosinix 4.1.1 is already out 😉 |
Hi,
I am running into a bug in IE11 with Bootstrap 4.1.0. I think it has to do with IE11 not fully supporting ES6. The bug happens in the following function. If I call $("#id").modal() (so there are no arguments passed when calling the function), then the code will break on Object.keys(source) because source evaluates to "false" here.
function _objectSpread(target) {
for (var i = 1; i < arguments.length; i++) {
var source = arguments[i] != null ? arguments[i] : {};
var ownKeys = Object.keys(source); <-- (code breaks here on 3rd iteration of loop)
The specific error I get in the IE11 Developer Tools console is "Object.keys: argument is not an Object".
If I do $("#id").modal({}) (so there is an empty object as an argument to the function), it works just fine.
I also found this resource on Object.keys(): https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/keys
That resource mentions the issue with ES5 and passing in non-object types.
Anyway, Bootstrap 4.0.0 does not have this issue, so we are using that for now. I'd like to use the latest though, so if this can be fixed in a newer version, please do so!
The text was updated successfully, but these errors were encountered: