Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with IE11 and Bootstrap 4.1.0 #26327

Closed
dustinrowland12 opened this issue Apr 17, 2018 · 7 comments
Closed

Issue with IE11 and Bootstrap 4.1.0 #26327

dustinrowland12 opened this issue Apr 17, 2018 · 7 comments

Comments

@dustinrowland12
Copy link

Hi,

I am running into a bug in IE11 with Bootstrap 4.1.0. I think it has to do with IE11 not fully supporting ES6. The bug happens in the following function. If I call $("#id").modal() (so there are no arguments passed when calling the function), then the code will break on Object.keys(source) because source evaluates to "false" here.

function _objectSpread(target) {
for (var i = 1; i < arguments.length; i++) {
var source = arguments[i] != null ? arguments[i] : {};
var ownKeys = Object.keys(source); <-- (code breaks here on 3rd iteration of loop)

The specific error I get in the IE11 Developer Tools console is "Object.keys: argument is not an Object".

If I do $("#id").modal({}) (so there is an empty object as an argument to the function), it works just fine.

I also found this resource on Object.keys(): https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/keys
That resource mentions the issue with ES5 and passing in non-object types.

Anyway, Bootstrap 4.0.0 does not have this issue, so we are using that for now. I'd like to use the latest though, so if this can be fixed in a newer version, please do so!

@dustinrowland12
Copy link
Author

dustinrowland12 commented Apr 17, 2018

bootstrap error

To add more information, I created a code pen: https://codepen.io/dustinrowland12/pen/GdKzKL
IE11 on Windows 10, Bootstrap version 4.1.0

@Johann-S
Copy link
Member

Already fixed by: #26291 and will be available in our next release 👍

@dustinrowland12
Copy link
Author

Thank you for the quick reply. Any thoughts on when the next release may come out? I'm sure that is always the golden question. I just want to be on the lookout for it.

Thanks again!

@Johann-S
Copy link
Member

We'll try to release a new version soon to fix some critical bugs. It'll be a 4.1.1 😉

@catbadger
Copy link

Sorry to prod, but we're pushing back release for 4.1.1. Is there a timeline for 4.1.1 yet?

@kosinix
Copy link

kosinix commented Jun 1, 2018

Should remove <=IE11 from the list of supported browsers until then.

@Johann-S
Copy link
Member

Johann-S commented Jun 1, 2018

@kosinix 4.1.1 is already out 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants