modem-manager-autosetup: Use optional mvno_match_data for APN selection #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktetzlaff
force-pushed
the
951-1-feat-use-mvno-match-data-to-improve-apn-info-selection
branch
from
37d1eb3
to
b40a446
Compare
The initial jq filter used to extract the APN info from apns-conf.json
fails with:
``` text
jq: error (...): null (null) and string ("default") cannot have their containment checked
```
when one of the apn objects selected by mcc/mnc doesn't have a
'type' attribute (as is the case for mcc=262, mnc=07). As a result,
otherwise matching APN objects will not be considered.
This commit fixes the jq filter by checking for the presence of
the 'type' attribute.
In case that there are multiple APN definitions for the given combination of 'mnc', 'nmc' (and 'type') and an 'mvno_match_data' attribute of type 'imsi' exists, the 'mvno_match_data' can be used to select the correct APN from a set of otherwise equivalent ones. This commit adds an additional step which uses 'mvno_match_data' to improve the APN selection process.
ktetzlaff
force-pushed
the
951-1-feat-use-mvno-match-data-to-improve-apn-info-selection
branch
from
b40a446
to
7a91d59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR builds on #2.
In case that there are multiple APN definitions for the given combination of
mnc,nmc(andtype) and anmvno_match_dataattribute of typeimsiexists, themvno_match_datacan be used to select the correct APN from a set of otherwise equivalent ones.This PR adds an additional step which uses
mvno_match_datato improve the APN selection process.This addresses the 2nd part of gitlab.nic.cz issue 951.