modem-manager-autosetup: Fix jq filter for apn without 'type' attribute #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktetzlaff
force-pushed
the
951-fix-apn-info-for-mcc262-mnc07
branch
from
f7534a2
to
bdf1624
Compare
ktetzlaff
force-pushed
the
951-fix-apn-info-for-mcc262-mnc07
branch
from
bdf1624
to
9d276ee
Compare
The initial jq filter used to extract the APN info from apns-conf.json
fails with:
``` text
jq: error (...): null (null) and string ("default") cannot have their containment checked
```
when one of the apn objects selected by mcc/mnc doesn't have a
'type' attribute (as is the case for mcc=262, mnc=07). As a result,
otherwise matching APN objects will not be considered.
This commit fixes the jq filter by checking for the presence of
the 'type' attribute.
ktetzlaff
force-pushed
the
951-fix-apn-info-for-mcc262-mnc07
branch
from
9d276ee
to
c61ac41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial jq filter used to extract the APN info from
apns-conf.jsonfails with:when one of the apn objects selected by mcc/mnc doesn't have a
typeattribute (as is the case for mcc=262, mnc=07). As a result, otherwise matching APN objects will not be considered.This commit fixes the jq filter by checking for the presence of the
typeattribute.This PR fixes gitlab.nic.cz issue 951.