Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix column network_access_policy in table azure_compute_disk closes #446 #447

Merged
merged 2 commits into from
Apr 5, 2022
Merged

Fix column network_access_policy in table azure_compute_disk closes #446 #447

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
731f1e5
Fix column network_access_policy in table azure_compute_disk closes #446
ParthaI Mar 15, 2022
2798dd3
removed the log statemenet
ParthaI Mar 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions azure/table_azure_compute_disk.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,7 @@ func tableAzureComputeDisk(_ context.Context) *plugin.Table {
Name: "network_access_policy",
Description: "Policy for accessing the disk via network",
Type: proto.ColumnType_STRING,
Transform: transform.FromField("DiskProperties.NetworkAccessPolicy"),
},
{
Name: "creation_data_option",
Expand Down Expand Up @@ -309,6 +310,7 @@ func listAzureComputeDisks(ctx context.Context, d *plugin.QueryData, _ *plugin.H

for _, disk := range result.Values() {
d.StreamListItem(ctx, disk)
plugin.Logger(ctx).Info("Network Access Policy without page ===>>", disk.NetworkAccessPolicy)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should take this out? Please do not leave debug statements in

// Check if context has been cancelled or if the limit has been hit (if specified)
// if there is a limit, it will return the number of rows required to reach this limit
if d.QueryStatus.RowsRemaining(ctx) == 0 {
Expand All @@ -324,6 +326,7 @@ func listAzureComputeDisks(ctx context.Context, d *plugin.QueryData, _ *plugin.H

for _, disk := range result.Values() {
d.StreamListItem(ctx, disk)
plugin.Logger(ctx).Info("Network Access Policy with page ===>>", disk.NetworkAccessPolicy)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

// Check if context has been cancelled or if the limit has been hit (if specified)
// if there is a limit, it will return the number of rows required to reach this limit
if d.QueryStatus.RowsRemaining(ctx) == 0 {
Expand Down