Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix column network_access_policy in table azure_compute_disk closes #446 #447

Merged
merged 2 commits into from
Apr 5, 2022
Merged

Fix column network_access_policy in table azure_compute_disk closes #446 #447

merged 2 commits into from
Apr 5, 2022

Conversation

ParthaI
Copy link
Contributor

@ParthaI ParthaI commented Mar 15, 2022

Integration test logs

Logs 
N/A

Example query results

Results 
> select name, network_access_policy from azure_compute_disk
+-----------------------------------------------------------+-----------------------+
| name                                                      | network_access_policy |
+-----------------------------------------------------------+-----------------------+
| newwarriors-AAA_OsDisk_1_eac82728fe9a4e58b3db75d0518dd24d | AllowAll              |
+-----------------------------------------------------------+-----------------------+

@ParthaI ParthaI self-assigned this Mar 15, 2022
@ParthaI ParthaI linked an issue Mar 15, 2022 that may be closed by this pull request
Fix column network_access_policy in table azure_compute_disk #446
Closed
cbruno10
cbruno10 requested changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@cbruno10 cbruno10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ParthaI Please see comments

azure/table_azure_compute_disk.go Outdated
@@ -309,6 +310,7 @@ func listAzureComputeDisks(ctx context.Context, d *plugin.QueryData, _ *plugin.H

for _, disk := range result.Values() {
d.StreamListItem(ctx, disk)
plugin.Logger(ctx).Info("Network Access Policy without page ===>>", disk.NetworkAccessPolicy)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should take this out? Please do not leave debug statements in

azure/table_azure_compute_disk.go Outdated
@@ -324,6 +326,7 @@ func listAzureComputeDisks(ctx context.Context, d *plugin.QueryData, _ *plugin.H

for _, disk := range result.Values() {
d.StreamListItem(ctx, disk)
plugin.Logger(ctx).Info("Network Access Policy with page ===>>", disk.NetworkAccessPolicy)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

@ParthaI ParthaI marked this pull request as draft March 15, 2022 12:21
@ParthaI ParthaI marked this pull request as ready for review March 16, 2022 04:24
@misraved misraved merged commit afc10ff into main Apr 5, 2022
@misraved misraved deleted the issue-446 branch April 5, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbruno10 cbruno10 cbruno10 approved these changes

@rajlearner17 rajlearner17 Awaiting requested review from rajlearner17

@bigdatasourav bigdatasourav Awaiting requested review from bigdatasourav

Assignees

@ParthaI ParthaI

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix column network_access_policy in table azure_compute_disk
3 participants
@ParthaI @cbruno10 @misraved