Skip to content

Commit

Permalink
Fixes to MySQL pipelining
Browse files Browse the repository at this point in the history
Fixes eclipse-vertx#1234, fixes eclipse-vertx#1235

Signed-off-by: Thomas Segismont <[email protected]>
  • Loading branch information
tsegismont committed Sep 16, 2022
1 parent 1ec3edc commit 0b1f66e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ public MySQLConnectOptions(SqlConnectOptions other) {
this.serverRsaPublicKeyPath = opts.serverRsaPublicKeyPath;
this.serverRsaPublicKeyValue = opts.serverRsaPublicKeyValue != null ? opts.serverRsaPublicKeyValue.copy() : null;
this.characterEncoding = opts.characterEncoding;
this.pipeliningLimit = opts.pipeliningLimit;
this.authenticationPlugin = opts.authenticationPlugin;
}
}
Expand All @@ -116,6 +117,7 @@ public MySQLConnectOptions(MySQLConnectOptions other) {
this.serverRsaPublicKeyPath = other.serverRsaPublicKeyPath;
this.serverRsaPublicKeyValue = other.serverRsaPublicKeyValue != null ? other.serverRsaPublicKeyValue.copy() : null;
this.characterEncoding = other.characterEncoding;
this.pipeliningLimit = other.pipeliningLimit;
this.authenticationPlugin = other.authenticationPlugin;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,6 @@ void encode(MySQLEncoder encoder) {
} else {
// CURSOR_TYPE_NO_CURSOR
sendStatementExecuteCommand(statement, statement.sendTypesToServer(), params, CURSOR_TYPE_NO_CURSOR);

// Close managed prepare statement
MySQLPreparedStatement ps = (MySQLPreparedStatement) this.cmd.ps;
if (ps.closeAfterUsage) {
sendCloseStatementCommand(ps);
}
}
}
}
Expand Down

0 comments on commit 0b1f66e

Please sign in to comment.