Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MySQLConnectOptions copy constructors ignore pipeliningLimit #1235

Closed
tsegismont opened this issue Sep 16, 2022 · 0 comments · Fixed by #1236
Closed

MySQLConnectOptions copy constructors ignore pipeliningLimit #1235

tsegismont opened this issue Sep 16, 2022 · 0 comments · Fixed by #1236
Assignees
@tsegismont
Labels
bug module:mysql
Milestone
4.3.4

Comments

@tsegismont
Copy link
Contributor

The copy constructors ignore pipeliningLimit. In practice, this prevents pooled connection to support pipelining.
@tsegismont tsegismont added this to the 4.3.4 milestone Sep 16, 2022
@tsegismont tsegismont self-assigned this Sep 16, 2022
tsegismont added a commit to tsegismont/vertx-sql-client that referenced this issue Sep 16, 2022
@tsegismont
Fixes to MySQL pipelining
0b1f66e 
Fixes eclipse-vertx#1234, fixes eclipse-vertx#1235

Signed-off-by: Thomas Segismont <[email protected]>
@tsegismont tsegismont mentioned this issue Sep 16, 2022
Merged
tsegismont added a commit to tsegismont/vertx-sql-client that referenced this issue Sep 20, 2022
@tsegismont
Fixes to MySQL pipelining
405283b 
Fixes eclipse-vertx#1234, fixes eclipse-vertx#1235

Signed-off-by: Thomas Segismont <[email protected]>
tsegismont added a commit that referenced this issue Sep 20, 2022
@tsegismont
Fixes to MySQL pipelining (#1236)
3958755 
* Fixes to MySQL pipelining

Fixes #1234, fixes #1235

Signed-off-by: Thomas Segismont <[email protected]>

* Add ProxySQL connectivity test

Signed-off-by: Thomas Segismont <[email protected]>

* Add a doc note about pipelining + proxies for MySQL

The proxy might not support it.

Signed-off-by: Thomas Segismont <[email protected]>

Signed-off-by: Thomas Segismont <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsegismont tsegismont

Labels
bug module:mysql
Projects
None yet
Milestone
4.3.4
Development

Successfully merging a pull request may close this issue.

Fixes to MySQL pipelining tsegismont/vertx-sql-client
1 participant
@tsegismont