Ignore errors from libs in node_modules folders
#110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
approved these changes
May 30, 2021
gabmontes
added a commit
to gabmontes/p-do-whilst
that referenced
this pull request
Aug 23, 2024
[email protected] reports errors in files within the node_modules folder. This is a known problem solved in tsdjs/tsd#110 and released in [email protected]. With the new version, all the checks pass.
gabmontes
added a commit
to gabmontes/p-do-whilst
that referenced
this pull request
Aug 23, 2024
`[email protected]` reports errors in files within the node_modules folder. This is a known problem solved in tsdjs/tsd#110 and released in `[email protected]`. But with that new version, `xo` fails to load `@typescript-eslint/parser`. Using `[email protected]` solves all the errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried a few different things here but it seems that ignoring diagnostics from
node_modulesfolders is a good enough workaround.An actual solution for this would be support from
tscto allow type-checking project-local.d.tsfiles while skipping.d.tsfiles fromnode_modules. The way things are right now,skipLibCheckwill disable type-checking.d.tsfiles everywhere which we definitely don't want. On the other hand, skipping type-checking for types fromnode_moduleswould bring enormous performance improvements, most time is spent by checking types there.I've also tried to mess a bit with
tsc, mostly by monkey-patching stuff. The problem is that it's pretty much impossible to know in advance which.d.tsfiles are required to correctly type check an application and which ones not. It mostly boils down to.d.tsfiles exposing stuff in the global scope or declaring modules with different names than the module they belong to. Most other cases should be discoverable by analyzing forimports,<reference ...directives and the like.Fixes #45
Fixes #76
Fixes #30