Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module should not venture outside directory #30

Closed
silverwind opened this issue Aug 23, 2019 · 2 comments · Fixed by #110
Closed

Module should not venture outside directory #30

silverwind opened this issue Aug 23, 2019 · 2 comments · Fixed by #110
Labels
bug Something isn't working

Comments

@silverwind
Copy link

silverwind commented Aug 23, 2019

Given a directory structure like

parent
  node_modules
  child
    package.json
    node_modules

When running with directory set to child, tsd tries to check files in parent/node_modules which it absolutely should not. parent/node_modules is a symlink in my case.

@SamVerschueren SamVerschueren added the bug Something isn't working label Sep 14, 2019
@SamVerschueren
Copy link
Collaborator

Just to be sure. How do you set the directory to child? Do you run tsd parent/child or do you have a package.json somewhere pointing to child?

Because the directory option is meant to point to a directory with only test files. Something like this

parent
  node_modules
  child
    package.json
    node_modules
    test-dir
      test.test-d.ts
      test2.test-d.ts

And then set directory to test-dir inside parent/child/package.json and run tsd parent/child.

Do I miss something here? Would be nice if I could reproduce this in a test case or something.

@BendingBender
Copy link
Collaborator

@silverwind Would you mind testing my branch (https://github.com/BendingBender/tsd/tree/ignore-errors-from-node-modules) and reporting whether it fixes the problem for you? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants