Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service Discovery optional attributes #344

Merged
merged 3 commits into from
Jul 28, 2023
Merged

Service Discovery optional attributes #344

merged 3 commits into from
Jul 28, 2023

Conversation

ahobson
Copy link
Contributor

@ahobson ahobson commented Jul 28, 2023

For service discovery, you can specify either the container_name and container_port or just port. You cannot specify all of them.

The error is

Specify a value for either 'port' or the 'containerName' and 'containerPort' combination, but not both

Without this change, the error is

│ The given value is not suitable for
│ module ...
│ declared at
│ ...
│ element 0: attribute "port" is required.

@ahobson ahobson requested a review from esacteksab July 28, 2023 13:36
travelar
travelar approved these changes Jul 28, 2023
View reviewed changes
Copy link

@travelar travelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahobson
Copy link
Contributor Author

ahobson commented Jul 28, 2023

This fixes #342

@ahobson ahobson merged commit ef9b075 into main Jul 28, 2023
@ahobson ahobson deleted the adh-service-optional-attrs branch July 28, 2023 14:47
@ahobson ahobson mentioned this pull request Jul 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travelar travelar travelar approved these changes

@esacteksab esacteksab Awaiting requested review from esacteksab

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahobson @travelar