Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service_registries variable is requiring optional parameters #342

Closed
Nava-JoshLong opened this issue Jun 7, 2023 · 3 comments
Closed

service_registries variable is requiring optional parameters #342

Nava-JoshLong opened this issue Jun 7, 2023 · 3 comments

Comments

@Nava-JoshLong
Copy link

Describe the bug

The service_registries variable has 4 parameters, and all 4 required from this module. In the underlying module that this calls, the only required parameter is registry_arn, they rest are listed as optional. When we try to add this functionality on an existing module, we have to specify all 4 parameters, or the module will fail validations. However, on existing ECS services, we do not need the port and container_port, because they are optional and dealt with by the ECS config JSON.

I think a way to fix this would to tweaking the variable structure so that it can accept those parameters not being there, and then main to set them if they are there, or null if not

To Reproduce
Steps to reproduce the behavior:

  1. Create a service without the service_registries section defined
  2. Update with adding that parameter
  3. You will either get an error because parameters are not set, or because they are and you don't need them

Expected behavior

The parameters are optional instead of required

@rpdelaney
Copy link
Contributor

Hey @Nava-JoshLong: What you're saying makes sense. If you want to send a PR, we'll set up a review. Thank you for the report!

@ahobson
Copy link
Contributor

ahobson commented Jul 28, 2023

I believe this is fixed with #344

@ahobson ahobson closed this as completed Jul 28, 2023
@Nava-JoshLong
Copy link
Author

@ahobson Awesome, thanks for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants