Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cdylib targets #598

Closed
wants to merge 2 commits into from
Closed

Allow cdylib targets #598

wants to merge 2 commits into from

Conversation

vgwidt
Copy link
Contributor

@vgwidt vgwidt commented Aug 26, 2023

Adds a check to see if artifact is a cdylib target to fix regression in #476. Fixes #575

Checklist

  • Updated CHANGELOG.md describing pertinent changes.
  • Updated README.md with pertinent info (may not always apply).
  • Updated site content with pertinent info (may not always apply).
  • Squash down commits to one or two logical commits which clearly describe the work you've done. If you don't, then Dodd will 🤓.

@ctron
Copy link
Collaborator

ctron commented Oct 5, 2023

I cherry-picked this into trunk-ng.

@arne-fuchs
Copy link

So only your fork supports cdylib? @vgwidt

@vgwidt
Copy link
Contributor Author

vgwidt commented Nov 24, 2023

ctron has it included in his fork as well, and he looks to be cutting releases in case you want other recent fixes: https://github.com/ctron/trunk

@ctron
Copy link
Collaborator

ctron commented Dec 12, 2023

This was brought back to trunk with PR #623 and it should be part of the next release of trunk too.

@ctron
Copy link
Collaborator

ctron commented Dec 13, 2023

This was released with trunk 0.18.0

@ctron ctron closed this Dec 13, 2023
@vgwidt vgwidt deleted the master branch December 15, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Cargo artifacts not found for target crate" probably caused by crate in a workspace
3 participants