-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix binary selection #476
Fix binary selection #476
Conversation
56b5d0b
to
7b6ddc3
Compare
44c4305
to
e17f331
Compare
Is anything still required from me to get this merged? |
Looks great! @samoylovfp I'm not sure why CI is not triggering. Do you mind rebasing your branch? Hopefully that will allow CI to be triggered. |
Will do in a couple of hours
…On Thu, Mar 23, 2023, 16:52 Anthony Dodd ***@***.***> wrote:
Looks great! @samoylovfp <https://github.com/samoylovfp> I'm not sure why
CI is not triggering. Do you mind rebasing your branch? Hopefully that will
allow CI to be triggered.
—
Reply to this email directly, view it on GitHub
<#476 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEB4TM7CI77BUDNTVTO34KLW5RPS3ANCNFSM6AAAAAATQWQOCI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
e17f331
to
94e9611
Compare
Really stretching the definition of a "couple", but here we are |
Planning to fix the tests during the next weekend |
@samoylovfp as it turns out, at least one of the test failures (building the webworker-gloo example) demonstrates that your changeset does what it says on the tin:
|
94e9611
to
10e947c
Compare
Whew, good thing the test was there! Here's how I understood the issue: So I made |
proceeding leads to indeterminte result where trunk picks up an arbitrary binary for the target. See trunk-rs#475
10e947c
to
1ae3b77
Compare
Gonna merge this after CI goes green. |
Checklist
Updated README.md with pertinent info (may not always apply).Updatedsite
content with pertinent info (may not always apply).I don't think updating README or
site
is warranted here.@thedodd please squash the commits if you think it is beneficial