This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Edit network id check #1528
Merged
Edit network id check #1528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnidan
reviewed
Dec 12, 2018
| `(${providerNetworkId}). Ensure that both the network and the ` + | ||
| `provider are properly configured.` | ||
| }; | ||
| if (JSON.stringify(providerNetworkId) !== JSON.stringify(network_id)) { |
There was a problem hiding this comment.
We should just use .toString() here. We want the loss of precision. Also, if providerNetworkId is a BN then we won't be able to JSONify that
gnidan
approved these changes
Dec 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1316
Compare string version of network id and edit Error instantiation in order to allow a string or number representation of the network_id.