Network id configuration doesn't protect user from deploying to different network

[tcoulter]

As we saw during the retreat demo, if you specify a specific number in your truffle config (say, 3), if the actual network id of the chain doesn't match, Truffle won't error (and it should, to protect the user from inadvertently deploying with real Ether).

Steps to repro:

1. Set Truffle config network id to 3.
2. Deploy to rinkeby (which has network id of 4). Notice Truffle doesn't error, and performs the deployment.

Note: This bug report was written very quickly because we're at the retreat demo. Feel free to ask me any questions if the above is unclear.

[stale]

Thank you for raising this issue! It has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you would like to keep this issue open, please respond with information about the current state of this problem.

[gnidan]

Not stale

[stale]

Thanks for your response! This issue is no longer considered stale and someone from the Truffle team will try to respond as soon as they can.

[gnidan]

Colony's build is failing, seems to be a result of the change in the above PR.

Relevant CI output:

...
Summary
=======
> Total deployments:   13
> Final cost:          0 ETH

Error: [object Object]
    at detectNetworkId (/home/circleci/colonyNetwork/node_modules/truffle/build/webpack:/packages/truffle-core/lib/environment.js:73:1)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:182:7)
Truffle v5.0.0-next.20 (core: 5.0.0-beta.2)

Looks like the error is constructed wrong here, although I might just be blanking on whether { message: "..." } is kosher.

Hard to say if there's a real problem, we may have caught a mismatch in the test suite :)

attn @eggplantzzz
cc @elenadimitrova

[gnidan]

This is done and released in v5.0.0. Let us know if you run into it again! Thanks!