Carbon dataloader and Internet search feature #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nita into carbondataloader
Merge branch main -> carbondl
chiragjn
reviewed
Sep 6, 2024
| if total == -1: | ||
| total = page.count | ||
| for file in page.results: | ||
| # TODO (chiragjn): There can be an edge case here where file.file_metadata.is_folder = True |
There was a problem hiding this comment.
I never got around to this.
Actually now that we support pydantic v2, we should be able to use the official carbon python sdk
chiragjn
reviewed
Sep 6, 2024
| response = self._request( | ||
| "POST", "https://api.carbon.ai/user_files_v2", json=payload | ||
| ) | ||
| page = _UserFilesV2Response.parse_obj(response) |
There was a problem hiding this comment.
This will break actually, this needs to be .model_validate
chiragjn
reviewed
Sep 6, 2024
| @@ -32,6 +32,7 @@ async def answer( | |||
| """ | |||
| Sample answer method to answer the question using the context from the collection | |||
| """ | |||
| logger.info(f"Request: {request.dict()}") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.