Added unstructured io parsers #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons, removed older parsers, modified multimodal parser to support images
innoavator
requested changes
Jul 16, 2024
chiragjn
reviewed
Jul 16, 2024
chiragjn
reviewed
Jul 16, 2024
chiragjn
reviewed
Jul 16, 2024
Comment on lines
+21
to
26
| "additional_config": { | ||
| "model_configuration": { | ||
| "name": "truefoundry/openai-main/gpt-4-turbo" | ||
| }, | ||
| "prompt": "Given an image containing one or more charts/graphs, and texts, provide a detailed analysis of the data represented in the charts. Your task is to analyze the image and provide insights based on the data it represents. Specifically, the information should include but not limited to: - Title of the Image: Provide a title from the charts or image if any. - Type of Chart: Determine the type of each chart (e.g., bar chart, line chart, pie chart, scatter plot, etc.) and its key features (e.g., labels, legends, data points). - Data Trends: Describe any notable trends or patterns visible in the data. This may include increasing/decreasing trends, seasonality, outliers, etc. - Key Insights: Extract key insights or observations from the charts. What do the charts reveal about the underlying data? Are there any significant findings that stand out? - Data Points: Identify specific data points or values represented in the charts, especially those that contribute to the overall analysis or insights. - Comparisons: Compare different charts within the same image or compare data points within a single chart. Highlight similarities, differences, or correlations between datasets. - Conclude with a summary of the key findings from your analysis and any recommendations based on those findings." | ||
| } |
There was a problem hiding this comment.
Please let's not stuff these things in additional_config
Can we please refactor
".pdf": {
"class": "MultiModalParser",
"kwargs": {
"...": "..."
}
}
chiragjn
reviewed
Jul 16, 2024
chiragjn
reviewed
Jul 16, 2024
chiragjn
reviewed
Jul 16, 2024
chiragjn
reviewed
Jul 16, 2024
Comment on lines
44
to
56
| self.session = requests.Session() | ||
| self.retry_strategy = Retry( | ||
| total=3, | ||
| backoff_factor=1, | ||
| status_forcelist=[429, 500, 502, 503, 504], | ||
| allowed_methods=["POST"], | ||
| ) | ||
| self.adapter = HTTPAdapter(max_retries=self.retry_strategy) | ||
| self.session.mount("https://", self.adapter) | ||
| self.session.mount("http://", self.adapter) | ||
| self.headers = { | ||
| "accept": "application/json", | ||
| } |
There was a problem hiding this comment.
All this retrying should be made a common utility across the repo
There was a problem hiding this comment.
will take this up as a separate PR
chiragjn
reviewed
Jul 16, 2024
chiragjn
reviewed
Jul 16, 2024
chiragjn
reviewed
Jul 16, 2024
Comment on lines
90
to
92
| except Exception as e: | ||
| logger.exception(f"Final Exception: {e}") | ||
| return final_texts |
There was a problem hiding this comment.
This is too aggressive error handling in my opinion, the caller should decide what they want to do this errors
This is general comment across all parsers that we maintain
Co-authored-by: Chirag Jain <[email protected]>
Co-authored-by: Chirag Jain <[email protected]>
Co-authored-by: Chirag Jain <[email protected]>
Co-authored-by: Chirag Jain <[email protected]>
Co-authored-by: Chirag Jain <[email protected]>
innoavator
approved these changes
Jul 16, 2024
chiragjn
reviewed
Jul 16, 2024
chiragjn
reviewed
Jul 16, 2024
chiragjn
reviewed
Jul 16, 2024
chiragjn
approved these changes
Jul 16, 2024
chiragjn
approved these changes
Jul 16, 2024
S1LV3RJ1NX
added a commit
that referenced
this pull request
Jul 16, 2024
Merge pull request #274 from truefoundry/ps_unstructured
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
".txt", ".eml", ".msg", ".xml", ".html", ".md", ".rst", ".json", ".rtf", ".jpeg", ".png", ".doc", ".docx", ".ppt", ".pptx", ".pdf", ".odt", ".epub", ".csv", ".tsv", ".xlsx"".png", ".jpeg", ".jpg"