Adapt 3d structured code to the new data structure #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sloede
requested changes
Apr 6, 2021
bennibolm
reviewed
Apr 7, 2021
sloede
approved these changes
Apr 8, 2021
Codecov Report
@@ Coverage Diff @@
## main #513 +/- ##
==========================================
+ Coverage 92.62% 93.81% +1.19%
==========================================
Files 124 124
Lines 12931 13019 +88
==========================================
+ Hits 11977 12214 +237
+ Misses 954 805 -149
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We adjusted the old 3d code to work with the new curved mesh on cuboid domains. This is just an intermediate PR on the way to 3d curvilinear domains, therefore some functions are rudimentary.