Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement dimension dispatch in max_dt on mesh/equations dimensions #515

Closed
sloede opened this issue Apr 6, 2021 · 0 comments · Fixed by #550
Closed

Implement dimension dispatch in max_dt on mesh/equations dimensions #515

sloede opened this issue Apr 6, 2021 · 0 comments · Fixed by #550

Comments

@sloede
Copy link
Member

sloede commented Apr 6, 2021

@ranocha IIRC, we only dispatch on u as an AbstractArray to differentiate between different dimensions. Now that we have the mesh and the equations, we could use either one of those to dispatch on the dimension. Wouldn't this be a cleaner approach?

I am not saying it should be done in this PR, I just didn't want to forget about it.

Originally posted by @sloede in #513 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

compare meshes, unify signatures, and improve performance trixi-framework/Trixi.jl
1 participant
@sloede